Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in pngimage.cpp (backport #1818) #1823

Merged
merged 3 commits into from
Aug 2, 2021
Merged

Fix memory leak in pngimage.cpp (backport #1818) #1823

merged 3 commits into from
Aug 2, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 1, 2021

This is an automatic backport of pull request #1818 done by Mergify.
Cherry-pick of 0eb235c has failed:

On branch mergify/bp/main/pr-1818
Your branch is ahead of 'origin/main' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 0eb235cd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/pngimage.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot added the conflicts label Aug 1, 2021
@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #1823 (141122b) into main (c65941c) will not change coverage.
The diff coverage is 69.23%.

❗ Current head 141122b differs from pull request most recent head c641116. Consider uploading reports for the commit c641116 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1823   +/-   ##
=======================================
  Coverage   60.51%   60.51%           
=======================================
  Files          96       96           
  Lines       18845    18845           
  Branches     9469     9470    +1     
=======================================
  Hits        11404    11404           
  Misses       5155     5155           
  Partials     2286     2286
Impacted Files Coverage Δ
src/pngimage.cpp 60.05% <69.23%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65941c...c641116. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit db25089 into main Aug 2, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1818 branch August 2, 2021 13:50
@nehaljwani nehaljwani mentioned this pull request Apr 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassec hassec hassec approved these changes

Assignees

@kevinbackhouse kevinbackhouse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hassec @kevinbackhouse